Cleanup C# projects, code quality & style
New rules: - Do not silence CA1805 any more - Limit where we silence CA1707, CA1711, CA1720 - Enforce severity=warning for IDE0040 - Enforce Allman style braces - Enforce naming conventions (IDE1006 is still severity=suggestion) Fixes: - Fix REFL045, CS1572, CS1573 - Suppress CS0618 when generating `InvokeGodotClassMethod` - Fix indent when generating GD_constants.cs - Temporarily silence CS1734 in generated code - Fix a lot of naming rule violations Misc.: - Remove ReSharper comments for RedundantNameQualifier - Remove suppression attributes for RedundantNameQualifier - Remove severity=warnings for CA1716, CA1304 (already included in the level of analysis we run)
This commit is contained in:
+4
-4
@@ -2,9 +2,9 @@ namespace Godot.SourceGenerators.Sample
|
||||
{
|
||||
public partial class AllReadOnly : GodotObject
|
||||
{
|
||||
public readonly string readonly_field = "foo";
|
||||
public string readonly_auto_property { get; } = "foo";
|
||||
public string readonly_property { get => "foo"; }
|
||||
public string initonly_auto_property { get; init; }
|
||||
public readonly string ReadonlyField = "foo";
|
||||
public string ReadonlyAutoProperty { get; } = "foo";
|
||||
public string ReadonlyProperty { get => "foo"; }
|
||||
public string InitonlyAutoProperty { get; init; }
|
||||
}
|
||||
}
|
||||
|
||||
+2
-2
@@ -4,7 +4,7 @@ namespace Godot.SourceGenerators.Sample
|
||||
{
|
||||
public partial class AllWriteOnly : GodotObject
|
||||
{
|
||||
bool writeonly_backing_field = false;
|
||||
public bool writeonly_property { set => writeonly_backing_field = value; }
|
||||
private bool _writeOnlyBackingField = false;
|
||||
public bool WriteOnlyProperty { set => _writeOnlyBackingField = value; }
|
||||
}
|
||||
}
|
||||
|
||||
+6
-6
@@ -2,12 +2,12 @@ namespace Godot.SourceGenerators.Sample
|
||||
{
|
||||
public partial class MixedReadonlyWriteOnly : GodotObject
|
||||
{
|
||||
public readonly string readonly_field = "foo";
|
||||
public string readonly_auto_property { get; } = "foo";
|
||||
public string readonly_property { get => "foo"; }
|
||||
public string initonly_auto_property { get; init; }
|
||||
public readonly string ReadOnlyField = "foo";
|
||||
public string ReadOnlyAutoProperty { get; } = "foo";
|
||||
public string ReadOnlyProperty { get => "foo"; }
|
||||
public string InitOnlyAutoProperty { get; init; }
|
||||
|
||||
bool writeonly_backing_field = false;
|
||||
public bool writeonly_property { set => writeonly_backing_field = value; }
|
||||
private bool _writeOnlyBackingField = false;
|
||||
public bool WriteOnlyProperty { set => _writeOnlyBackingField = value; }
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user