From c31a20c33c61431e5213f8230e60979da3fcb73d Mon Sep 17 00:00:00 2001 From: aaronp64 Date: Mon, 5 Jan 2026 19:24:22 -0500 Subject: [PATCH] Fix crash when trying to open Favorites externally Updated FileSystemDock logic for opening selection in terminal/external program/file manager to return early when only Favorites is selected. --- editor/docks/filesystem_dock.cpp | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/editor/docks/filesystem_dock.cpp b/editor/docks/filesystem_dock.cpp index e6249c6304..f65398ec23 100644 --- a/editor/docks/filesystem_dock.cpp +++ b/editor/docks/filesystem_dock.cpp @@ -2214,6 +2214,9 @@ void FileSystemDock::_file_option(int p_option, const Vector &p_selected // Show the file/folder in the OS explorer. String fpath = current_path; if (current_path == "Favorites") { + if (p_selected.is_empty()) { + return; + } fpath = p_selected[0]; } @@ -2224,6 +2227,9 @@ void FileSystemDock::_file_option(int p_option, const Vector &p_selected case FILE_MENU_OPEN_EXTERNAL: { String fpath = current_path; if (current_path == "Favorites") { + if (p_selected.is_empty()) { + return; + } fpath = p_selected[0]; } @@ -2261,6 +2267,9 @@ void FileSystemDock::_file_option(int p_option, const Vector &p_selected case FILE_MENU_OPEN_IN_TERMINAL: { String fpath = current_path; if (current_path == "Favorites") { + if (p_selected.is_empty()) { + return; + } fpath = p_selected[0]; }