noahbackus/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Merge pull request #85180 from AThousandShips/self_list_fix

Browse Source 
[Core] Prevent copying of `SelfList` and `SelfList::List`
This commit is contained in:
Rémi Verschelde
2024-01-08 11:51:27 +01:00
parent b88535fe23 904ecb1d36
commit 81f618d63a
2 changed files with 6 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/templates/self_list.h
+6
View File
@@ -159,6 +159,9 @@ public:
_FORCE_INLINE_ SelfList<T> *first() { return _first; }
_FORCE_INLINE_ const SelfList<T> *first() const { return _first; }
// Forbid copying, which has broken behavior.
void operator=(const List &) = delete;
_FORCE_INLINE_ List() {}
_FORCE_INLINE_ ~List() {
// A self list must be empty on destruction.
@@ -185,6 +188,9 @@ public:
_FORCE_INLINE_ const SelfList<T> *prev() const { return _prev; }
_FORCE_INLINE_ T *self() const { return _self; }
// Forbid copying, which has broken behavior.
void operator=(const SelfList<T> &) = delete;
_FORCE_INLINE_ SelfList(T *p_self) {
_self = p_self;
}