noahbackus/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Use Ref<T> references as iterators where relevant

Browse Source 
And const when possible.
This commit is contained in:
Rémi Verschelde
2021-07-26 17:50:35 +02:00
parent fef27e9b5b
commit 92299989bd
18 changed files with 62 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scene/animation/tween.cpp
+4 -4
View File
@@ -46,8 +46,8 @@ void Tween::start_tweeners() {
ERR_FAIL_MSG("Tween without commands, aborting.");
}
for (Ref<Tweener> E : tweeners.write[current_step]) {
E->start();
for (Ref<Tweener> &tweener : tweeners.write[current_step]) {
tweener->start();
}
}
@@ -253,11 +253,11 @@ bool Tween::step(float p_delta) {
float step_delta = rem_delta;
step_active = false;
for (Ref<Tweener> E : tweeners.write[current_step]) {
for (Ref<Tweener> &tweener : tweeners.write[current_step]) {
// Modified inside Tweener.step().
float temp_delta = rem_delta;
// Turns to true if any Tweener returns true (i.e. is still not finished).
step_active = E->step(temp_delta) || step_active;
step_active = tweener->step(temp_delta) || step_active;
step_delta = MIN(temp_delta, rem_delta);
}