noahbackus/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Fix some Coverity warnings in String API

Browse Source 
- StringName::StringName(const StringName &p_name)
  Non-static class member _data is not initialized in this constructor nor in any functions that it calls.

- StringName::_Data()
  Non-static class member idx is not initialized in this constructor nor in any functions that it calls.

- String::num_uint64(...)
  This less-than-zero comparison of an unsigned value is never true. n % base < 0UL.

- String::hex_to_int(...) and String::hex_to_int64(...)
  Execution cannot reach this statement (deadcode)
This commit is contained in:
Rémi Verschelde
2018-04-18 22:20:39 +02:00
parent 9ce8d8ddda
commit 9a75975042
3 changed files with 13 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
core/string_db.cpp
View File

@@ -164,21 +164,14 @@ void StringName::operator=(const StringName &p_name) {
_data = p_name._data;
}
}
/* was inlined
StringName::operator String() const {
if (_data)
return _data->get_name();
return "";
}
*/
StringName::StringName(const StringName &p_name) {
ERR_FAIL_COND(!configured);
_data = NULL;
if (p_name._data && p_name._data->refcount.ref()) {
ERR_FAIL_COND(!configured);
if (p_name._data && p_name._data->refcount.ref()) {
_data = p_name._data;
}
}