noahbackus/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

fix: prevent dragging unselected items from FileSystem dock

Browse Source 
When clicking empty space or an unselected item in the file list panel,
`get_drag_data_fw` previously returned the full selection, causing the
wrong files to appear dragged during the deadzone before the drag
actually starts.

Guard on both `get_item_at_position` returning -1 (empty space) and
the item not being selected, so only deliberate drags on the current
selection initiate drag-and-drop.

Fixes #119358.
This commit is contained in:
June Kim
2026-05-09 09:21:07 -07:00
parent aaaf76403e
commit c92b824830
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
editor/docks/filesystem_dock.cpp
+5
View File
@@ -3032,6 +3032,11 @@ Variant FileSystemDock::get_drag_data_fw(const Point2 &p_point, Control *p_from)
paths = _tree_get_selected();
}
} else if (p_from == files) {
// Don't allow dragging from empty space in the file list.
int item = files->get_item_at_position(p_point, true);
if (item == -1 || !files->is_selected(item)) {
return Variant();
}
for (int i = 0; i < files->get_item_count(); i++) {
if (files->is_selected(i)) {
paths.push_back(files->get_item_metadata(i));