Add support for PiP mode

platform/android/java/editor/src/main/java/org/godotengine/editor/GodotGame.kt

@@ -30,12 +30,7 @@
 
 package org.godotengine.editor
 
-import android.app.PictureInPictureParams
-import android.content.pm.PackageManager
-import android.graphics.Rect
-import android.os.Build
 import android.os.Bundle
-import android.util.Log
 import android.view.View
 import androidx.annotation.CallSuper
 import androidx.core.view.isVisible
@@ -55,7 +50,6 @@ open class GodotGame : BaseGodotGame() {
 		private val TAG = GodotGame::class.java.simpleName
 	}
 
-	private val gameViewSourceRectHint = Rect()
 	private val expandGameMenuButton: View? by lazy { findViewById(R.id.game_menu_expand_button) }
 
 	override fun onCreate(savedInstanceState: Bundle?) {
@@ -75,13 +69,6 @@ open class GodotGame : BaseGodotGame() {
 				gameMenuFragment?.expandGameMenu()
 			}
 		}
-
-		if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
-			val gameView = findViewById<View>(R.id.godot_fragment_container)
-			gameView?.addOnLayoutChangeListener { v, left, top, right, bottom, oldLeft, oldTop, oldRight, oldBottom ->
-				gameView.getGlobalVisibleRect(gameViewSourceRectHint)
-			}
-		}
 	}
 
 	override fun getCommandLine(): MutableList<String> {
@@ -96,27 +83,7 @@ open class GodotGame : BaseGodotGame() {
 		return updatedArgs
 	}
 
-	override fun enterPiPMode() {
-		if (hasPiPSystemFeature()) {
-			if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
-				val builder = PictureInPictureParams.Builder().setSourceRectHint(gameViewSourceRectHint)
-				if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
-					builder.setSeamlessResizeEnabled(false)
-				}
-				setPictureInPictureParams(builder.build())
-			}
-
-			Log.v(TAG, "Entering PiP mode")
-			enterPictureInPictureMode()
-		}
-	}
-
-	/**
-	 * Returns true the if the device supports picture-in-picture (PiP).
-	 */
-	protected fun hasPiPSystemFeature(): Boolean {
-		return packageManager.hasSystemFeature(PackageManager.FEATURE_PICTURE_IN_PICTURE)
-	}
+	override fun isPiPEnabled() = true
 
 	override fun shouldShowGameMenuBar(): Boolean {
 		return intent.getBooleanExtra(
@@ -127,21 +94,11 @@ open class GodotGame : BaseGodotGame() {
 
 	override fun onPictureInPictureModeChanged(isInPictureInPictureMode: Boolean) {
 		super.onPictureInPictureModeChanged(isInPictureInPictureMode)
-		Log.v(TAG, "onPictureInPictureModeChanged: $isInPictureInPictureMode")
 
 		// Hide the game menu fragment when in PiP.
 		gameMenuContainer?.isVisible = !isInPictureInPictureMode
 	}
 
-	override fun onStop() {
-		super.onStop()
-
-		if (isInPictureInPictureMode && !isFinishing) {
-			// We get in this state when PiP is closed, so we terminate the activity.
-			finish()
-		}
-	}
-
 	override fun getGodotAppLayout() = R.layout.godot_game_layout
 
 	override fun getEditorWindowInfo() = RUN_GAME_INFO
@@ -258,7 +215,7 @@ open class GodotGame : BaseGodotGame() {
 
 	override fun isCloseButtonEnabled() = !isHorizonOSDevice(applicationContext)
 
-	override fun isPiPButtonEnabled() = hasPiPSystemFeature()
+	override fun isPiPButtonEnabled() = isPiPModeSupported()
 
 	override fun isMenuBarCollapsable() = true
 

platform/android/java/editor/src/main/java/org/godotengine/editor/embed/EmbeddedGodotGame.kt

@@ -140,7 +140,7 @@ class EmbeddedGodotGame : GodotGame() {
 
 	override fun isMenuBarCollapsable() = false
 
-	override fun isAlwaysOnTopSupported() = hasPiPSystemFeature()
+	override fun isAlwaysOnTopSupported() = isPiPModeSupported()
 
 	override fun onFullScreenUpdated(enabled: Boolean) {
 		godot?.enableImmersiveMode(enabled)

platform/android/java/editor/src/main/java/org/godotengine/editor/embed/GameMenuFragment.kt

@@ -47,6 +47,7 @@ import androidx.fragment.app.Fragment
 import org.godotengine.editor.BaseGodotEditor
 import org.godotengine.editor.BaseGodotEditor.Companion.SNACKBAR_SHOW_DURATION_MS
 import org.godotengine.editor.R
+import org.godotengine.godot.feature.PictureInPictureProvider
 import org.godotengine.godot.utils.DialogUtils
 
 /**
@@ -65,7 +66,7 @@ class GameMenuFragment : Fragment(), PopupMenu.OnMenuItemClickListener {
 	/**
 	 * Used to be notified of events fired when interacting with the game menu.
 	 */
-	interface GameMenuListener {
+	interface GameMenuListener : PictureInPictureProvider {
 
 		/**
 		 * Kotlin representation of the RuntimeNodeSelect::SelectMode enum in 'scene/debugger/scene_debugger.h'.
@@ -109,7 +110,6 @@ class GameMenuFragment : Fragment(), PopupMenu.OnMenuItemClickListener {
 		fun isGameEmbeddingSupported(): Boolean
 		fun embedGameOnPlay(embedded: Boolean)
 
-		fun enterPiPMode() {}
 		fun minimizeGameWindow() {}
 		fun closeGameWindow() {}