Commit Graph

1145 Commits

Author SHA1 Message Date
Thaddeus Crews f5560ccbe2 Merge pull request #115637 from YeldhamDev/obey_your_parents
Make internal children of built-in nodes use their parent's material
2026-04-28 09:02:46 -05:00
Thaddeus Crews 1aabcb9e9b Merge pull request #118306 from StarryWorm/text-edit-max-size
Make `TextEdit`'s `scroll_fit_content_*` properties work properly with maximum sizes
2026-04-10 10:32:44 -05:00
Chaosus 34777ad0e4 Implement inline text shader previews
Co-authored-by: Cashew OldDew <155181921+cashew-olddew@users.noreply.github.com>
2026-04-10 08:40:02 +03:00
Leeso 3b0e821440 TextEdit: Ensure caret is visible after paste 2026-04-08 10:01:48 -05:00
Michael Alexsander 37da25dcb0 Make internal children of built-in nodes use their parent's material 2026-04-08 11:45:49 -03:00
StarryWorm 747c3deeb5 TextEdit::scroll_fit_content_* is now maximum size aware
If `Control::get_combined_maximum_size()` returns a size smaller than `get_minimum_size()` in the target axis, scrollbars are shown.
2026-04-08 08:36:53 -04:00
StarryWorm bdca8b66e7 Add custom_maximum_size to Control
This property mirrors `custom_minimum_size` and enables the user to set a size the `Control`. Enabling `propagate_maximum_size` forces all children to respect this node's maximum_size.
Not all `Control` types handle this gracefully, which may result in content clipping.
2026-04-07 14:34:12 -04:00
Thaddeus Crews 3eb96c8313 Merge pull request #117244 from bruvzg/ii
Do not show accessibility configuration warnings for non-focusable controls, account for name fallback.
2026-03-30 13:35:35 -05:00
Rémi Verschelde 151eeb8a64 Merge pull request #117612 from jack-klein-5/fix-adding-caret-above-then-below
Fix adding carets above and then below
2026-03-23 22:35:20 +01:00
Rémi Verschelde 8a72ab019d Merge pull request #117154 from BrotherShort/fix-textedit-bugs-with-large-linespacing
Fix `TextEdit` bugs with large `line_spacing`
2026-03-23 22:34:21 +01:00
Pāvels Nadtočajevs 300ae1ba32 [TextEdit] Ignore IME updates and Alt sequences when control is read-only. 2026-03-19 21:57:39 +02:00
BrotherShort 5e0c7940d5 Fix TextEdit bugs with large line_spacing 2026-03-20 01:40:45 +08:00
jack-klein-5 10efa6d1f3 Fix adding carets above and then below
Fix bug #117549 where adding a caret on the line
above then the line below and then above again
results in carets no longer being added.
2026-03-19 00:10:24 -07:00
Rémi Verschelde 7795057e4b Misc includes or modernize fixes found via clangd-tidy 2026-03-16 21:38:26 +01:00
Anyone4551 4c8b5f960f [TextEdit] Fix right margin rounding clipping last character 2026-03-16 11:09:55 -05:00
Pāvels Nadtočajevs cdb35db426 Do not show accessibility configuration warnings for non-focusable controls, account for name fallback. 2026-03-13 08:53:09 +02:00
Goldenlion5648 c6b70a71e5 make caret at end of word work for lookup 2026-03-11 15:50:28 -04:00
Rémi Verschelde 2dd1f4ef60 Decouple node.h from scene_tree.h, minimize its other includes 2026-03-05 13:54:46 +01:00
Thaddeus Crews db25be3646 Merge pull request #116585 from jinyangcruise/fix_symbol_jump
Fix symbol jump history navigation issue.
2026-03-04 11:20:33 -06:00
Rémi Verschelde eabb9a63d4 Rename callable_method_pointer.h to callable_mp.h and include it explicitly
This allows removing it from `class_db.h`, significantly reducing the amount of files
that include it transitively.

Also includes some include cleanup in `control.h` and `rich_text_label.h` done while
ensure they don't depend on `callable_mp`.
2026-03-04 16:23:23 +01:00
Rémi Verschelde 765362b033 Explicitly include core/config/engine.h where used 2026-03-04 10:17:10 +01:00
Rémi Verschelde 8c0f175c94 Decouple RenderingServer from as much of the codebase as possible
Notably decouples it from:
- AccessibilityServer
- DisplayServer
- Viewport
- Window
2026-03-03 12:48:07 +01:00
Rémi Verschelde a447ac95ec Move DisplayServer enums and typedefs to DisplayServerEnums
This will allow decoupling `display_server.h` from a number of headers in the
codebase which only require those enums and not all the DisplayServer API.
2026-03-03 12:44:02 +01:00
Pāvels Nadtočajevs 1306221592 Move accessibility methods/enums from DisplayServer to the AccessibilityServer dedicated singleton. 2026-03-02 13:48:29 +02:00
jinyangcruise e4e31abeaa fix symbol jump history navigation issue. 2026-02-28 09:45:06 +08:00
Thaddeus Crews e380a41752 Style: Add class_db.h includes explicitly 2026-02-26 15:50:28 -06:00
Thaddeus Crews edb345db45 Merge pull request #116678 from Giganzo/text-edit-focus-showing
Fix TextEdit showing focus on some mouse events
2026-02-26 08:15:18 -06:00
Rémi Verschelde f5a290ac46 Move RenderingServer enums to a dedicated RenderingServerEnums (RSE) namespace
A number of headers in the codebase included `rendering_server.h` just for
some enum definitions. This means that any change to `rendering_server.h` or
one of its dependencies would trigger a massive incremental rebuild.

With this change, we decouple a number of classes from `rendering_server.h`,
greatly speeding up incremental rebuilds for that area.

On my machine, this reduces incremental compilation time after an edit of
`rendering_server.h` by 60s (from 2m57s).
2026-02-25 19:43:03 +01:00
Giganzo fbc9af0693 Fix TextEdit showing focus on some mouse events 2026-02-23 19:06:52 +01:00
Thaddeus Crews 781ae8deb2 Merge pull request #115876 from kitbdev/fix-te-search-backwards
Fix TextEdit backwards search skipping matches
2026-02-20 11:36:08 -06:00
Thaddeus Crews 79eb6694a1 Merge pull request #112381 from Ivorforce/no-right-align
Don't right-align escaped newlines (e.g. for `#define`)
2026-02-05 09:18:36 -06:00
kit 0806343998 Fix TextEdit backwards search skipping matches 2026-02-04 14:30:58 -05:00
Lukas Tenbrink c5df0cb82b Don't right-align escaped newlines, e.g. for #define. This has previously led to long diffs in the commit history. 2026-02-04 19:31:28 +01:00
Thaddeus Crews 77f596abc5 Merge pull request #115729 from Manik2607/fix-current-line-highlight-gutter
Fix current line highlight not extending into gutter
2026-02-02 12:57:29 -06:00
Manik Sharma 4dfbd909ac Fix current line highlight not extending into gutter
Fixes regression where current line highlight no longer extends
into the gutter area. The highlight now starts from 0 instead of
xmargin_beg, making it extend all the way to the left edge.

This restores the 4.5.1 behavior where the current line highlight
spans the entire line including the gutter area and left margin.
2026-02-02 16:33:56 +05:30
kobewi f7b9703cbd Use actual class names in resource type hints 2026-01-29 21:07:56 +01:00
Thaddeus Crews ae7d2defe2 Merge pull request #115006 from kitbdev/fix-te-editable-draw-caret
Fix TextEdit not drawing caret on setting editable
2026-01-27 09:04:04 -06:00
Thaddeus Crews 86b40d4439 Merge pull request #111859 from kitbdev/fix_te_ime_wrap_index_error
Fix TextEdit IME error on mouse over
2026-01-26 13:14:35 -06:00
kit f2e370cfd3 Fix TextEdit not drawing caret on setting editable 2026-01-15 14:04:02 -05:00
kit 9813c834fa Fix TextEdit Shift+Click selection start position 2026-01-09 10:46:45 -05:00
Rémi Verschelde 3349d14f84 Merge pull request #114404 from kitbdev/fix-te-move-caret-word-hidden
Fix TextEdit moving caret word left/right can hide the caret
2026-01-01 16:47:30 +01:00
Adam Scott 263589497b Add non-public {Line,Text}Edit::_set_text()
- [Web] Fix "Enter" not triggering LineEdit submits.

Co-authored-by: Marwen Azouzi <marwen.azouzi@datadoghq.com>
2026-01-01 12:00:52 +01:00
kit cbc3a989fb Fix TextEdit moving caret word left/right can hide 2025-12-28 16:42:29 -05:00
Rémi Verschelde e7d8609c73 Merge pull request #113390 from X1Vi/text-edit-does-not-auto-scroll-113290
Fix `TextEdit` does not auto scroll properly on certain vertical sizes
2025-12-12 17:13:00 +01:00
X1Vi 442c117fb7 fix: scrollbar range fix and new tests for the same
fix: now the scrollbar also should work within the range it is provided

adjusted the tests according to the new scrollbar functinality

attempted to fix testcases for scrollbar
2025-12-12 18:31:19 +05:30
Nolan Darilek 6304e9f876 Accessibility: Fix text field character count and line navigation
Two fixes for text field accessibility:

1. Fix character count being off by one due to trailing newline always
   being appended to the last line. Add `is_last_line` parameter to
   `accessibility_create_sub_text_edit_elements()` to control this.

2. Link adjacent TextRuns via `previous_on_line`/`next_on_line` so
   screen readers can properly navigate lines. Without these links,
   AccessKit treats each TextRun as a separate line, causing incorrect
   announcements when arrowing through multi-line text.
2025-12-03 07:19:05 -05:00
kobewi e14263f917 Remove empty constructors and destructors from core/ 2025-11-17 20:09:05 +01:00
kit e2cbfb53f1 Deprecate TextEdit background_color 2025-11-13 22:48:04 -05:00
Thaddeus Crews 82e6303634 Merge pull request #111535 from kitbdev/fix-textedit-dont-select
Fix TextEdit selecting when closing popup
2025-11-10 08:20:08 -06:00
Thaddeus Crews 6d32d3df75 Merge pull request #111766 from kitbdev/speed_up_spinbox_creation
Improve performance of SpinBox creation
2025-10-27 10:01:35 -05:00