Commit Graph

2632 Commits

Author SHA1 Message Date
Dalton Lang
9cb9c28c3c Make HTTPRequest 301 and 302 Redirects Standards-Compliant
The behavior of 301 and 302 redirects in the HTTPRequest node are not
standards-compliant. Specifically, requests using unsafe methods were not
being changed to GET and their headers were not being modified. This
means that we were automatically redirecting POST, PUT, etc. requests
with empty bodies and the same headers. This can pose a security risk if
the server expects 301/302 responses to get changed to GET or if the
user doesn't expect unsafe methods to be automatically redirected.

Per
[RFC9110](https://www.rfc-editor.org/rfc/rfc9110#name-redirection-3xx),
the correct behavior is to change the method to GET for 301 and 302
redirections and remove any content headers as well as those related to
security contexts like "Authorization: ".

I have made these changes, so now the 301 and 302 redirects should
change any unsafe methods to GET and remove any sensitive headers.

GET, HEAD, OPTIONS, and TRACE requests that receive a 301 or 302 are
automatically forwarded unchanged since those methods are safe.

Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2026-01-09 14:07:30 +01:00
Pāvels Nadtočajevs
89372664a2 [Accessibility] Force keyboard focus to the exclusive child. 2026-01-08 08:32:57 +02:00
Adam Scott
263589497b Add non-public {Line,Text}Edit::_set_text()
- [Web] Fix "Enter" not triggering LineEdit submits.

Co-authored-by: Marwen Azouzi <marwen.azouzi@datadoghq.com>
2026-01-01 12:00:52 +01:00
Rémi Verschelde
e51c6e9fe8 Merge pull request #111797 from KoBeWi/c-c-combo_breaker
Fix scale factor applied twice
2025-12-19 11:53:02 +01:00
Rémi Verschelde
43f966772d Merge pull request #112712 from bruvzg/mo_e
Use event position for mouse over when event come from the same window.
2025-12-18 14:23:48 +01:00
Rémi Verschelde
d08fbbcc0d Merge pull request #114072 from Fahien/include-cstdlib
Add missing `cstdlib` include for `EXIT_SUCCESS` and `free`
2025-12-16 11:27:13 +01:00
Antonio Caggiano
717a7f1d76 Add missing cstdlib include for EXIT_SUCCESS and free 2025-12-16 11:02:07 +01:00
Dery Almas
99b109e981 Wayland: Work around window scale ambiguity 2025-12-06 00:54:50 +01:00
David Snopek
6d60660cd6 Unmark Node::is_editable_instance() parameter as required 2025-12-03 08:34:04 -06:00
David Snopek
308f23f21d Synchronize the names for RequiredParam<T> arguments in header files 2025-12-03 04:14:52 -06:00
Thaddeus Crews
9f76aa3df5 Merge pull request #113282 from dsnopek/required-ptr-get-out-there
Use `RequiredParam`/`RequiredResult` in some high value places
2025-12-02 20:42:53 -06:00
Thaddeus Crews
dec0b22f7d Merge pull request #64487 from Rindbee/fix-instantiated-scene-duplicate
Fix resource shared when duplicating an instanced scene
2025-12-02 11:52:13 -06:00
David Snopek
fc92ce3e7f Use RequiredParam/RequiredResult in some high value places 2025-12-02 10:44:12 -06:00
Rémi Verschelde
e55bc69093 Merge pull request #113218 from Calinou/thread-group-error-message-add-function
Mention the called function name in thread group error messages
2025-12-02 14:16:46 +01:00
Rindbee
e0532a711a Fix resource shared when duplicating an instanced scene
For resources with `resource_local_to_scene` enabled in the sub-scene,
the resource is already set when the sub-scene is instantiated, so does
not need to be set again. Just needs to update the property of the
resource according to the value in the main scene.
2025-12-02 20:45:54 +08:00
Hugo Locurcio
230ca1d673 Mention the called function name in thread group error messages
This makes it easier to troubleshoot issues related to invalid
thread group usage.
2025-11-27 23:00:23 +01:00
Pāvels Nadtočajevs
e68b2436ee [Editor] Simplify native menu icon generation. 2025-11-27 23:04:51 +02:00
Thaddeus Crews
5afc01c46d Merge pull request #112604 from bruvzg/pop_center_rec
Update rect after `_pre_popup` in `popup_centered_*`.
2025-11-25 09:52:38 -06:00
Thaddeus Crews
5ff7a9e793 Merge pull request #112031 from bruvzg/vm_os_f
Fix embedded window frame oversampling, fix DPITexture using uninitialized size in some conditions.
2025-11-25 09:52:24 -06:00
David Snopek
090a4540b7 Use RequiredParam and RequiredResult in a handful of places in order to test 2025-11-24 12:12:10 -06:00
Thaddeus Crews
bbe9654327 Merge pull request #111484 from HolonProduction/rm-debugger-shortcut
Remove unused `Window::debugger_stop_shortcut`
2025-11-24 10:21:47 -06:00
Florea Andrei
35a6ba5ff9 Fix a thread warning 2025-11-22 22:17:36 +01:00
kobewi
67735cf213 Make bottom panel into available dock slot 2025-11-21 18:52:13 +01:00
Pāvels Nadtočajevs
179d1b763b Use safe ObjectID for mouse over controls. 2025-11-18 20:18:12 +02:00
Thaddeus Crews
462a8d65bf Merge pull request #110162 from bruvzg/m_cli
Fix out of control area mouse events crash, if nothing have mouse focus.
2025-11-18 08:25:46 -06:00
Thaddeus Crews
7d5034c50a Merge pull request #108507 from dementive/optimize-scene-tree-groups
Optimize scene tree groups
2025-11-14 14:22:57 -06:00
Thaddeus Crews
6a3d1f1fa1 Merge pull request #57121 from KoBeWi/noddeganger
Add `DUPLICATE_INTERNAL_STATE` flag
2025-11-13 17:42:47 -06:00
Thaddeus Crews
d2ff4c6377 Merge pull request #112401 from xuhuisheng/dev/queue-free
Fix crash on queue free scene node in editor
2025-11-13 12:33:37 -06:00
xuhuisheng
63d1319674 Fixes crash on queue free scene node in editor
Update scene/main/node.cpp

Co-authored-by: Lukas Tenbrink <lukas.tenbrink@gmail.com>
2025-11-13 21:10:44 +08:00
Pāvels Nadtočajevs
a6f6d7118e Use event position for mouse over when event come from the same window. 2025-11-13 08:26:11 +02:00
Hugo Locurcio
b7f537c863 Fix HTTPRequest timeout being scaled with Engine.time_scale
The server's response time won't change according to the engine's
time scale, so the timeout shouldn't be adjusted accordingly.
2025-11-12 23:55:29 +01:00
Thaddeus Crews
04bc282ae7 Merge pull request #104851 from Ivorforce/tracy
Add `profiler` option to `SCons` builds, with support for `tracy` and `perfetto`.
2025-11-12 11:24:15 -06:00
Thaddeus Crews
72925d756f Merge pull request #112076 from kevinlam508/custom-node-reference-duplication
Fix duplicating node references of custom node type properties
2025-11-11 16:07:53 -06:00
Pāvels Nadtočajevs
adf18ff44d Update rect after _pre_popup in popup_centered_*. 2025-11-10 11:24:37 +02:00
Lukas Tenbrink
c3747884da Add some important profiling hooks. 2025-11-08 00:08:48 +01:00
Thaddeus Crews
eb3d6d8cd3 Merge pull request #112446 from Ivorforce/revert-warn-rename
Revert "Add warning when node name is invalid"
2025-11-05 13:05:48 -06:00
Thaddeus Crews
3b4239d649 Merge pull request #111288 from bruvzg/move_input
[Window] Add unfiltered input handler signal for custom decorations.
2025-11-05 11:48:06 -06:00
Lukas Tenbrink
78096d4ce7 Revert "Add warning when node name is invalid"
This reverts commit 0d46d42f2a.
2025-11-05 18:11:43 +01:00
Thaddeus Crews
80b82af92b Merge pull request #111163 from HolonProduction/node-greater-than
Speed up `Node::is_greater_than` by avoiding `alloca`
2025-11-04 16:32:42 -06:00
Thaddeus Crews
2ac27b2fa0 Merge pull request #112307 from AdvanceControl/add_warn_when_renamed_node
Add warning when node name is invalid
2025-11-04 16:32:41 -06:00
HolonProduction
8c5e67a514 Speedup Node::is_greater_than by avoiding alloca 2025-11-04 17:34:08 +01:00
Michael Alexsander
e32b9274a3 Fix UI focus being shown when it shouldn't 2025-11-03 17:00:05 -03:00
AdvanceControl
0d46d42f2a Add warning when node name is invalid 2025-11-03 17:52:25 +08:00
Thaddeus Crews
416ba9a1c6 Merge pull request #109517 from precup/speedy-signal-disconnect
Speed up signal disconnects in the editor
2025-10-30 10:45:56 -05:00
Kevin Lam
b9cc82df40 Fix duplicating node references of custom node type properties
Script assignment must be complete for the subtree in order to correctly assign into properties set to a script type.
2025-10-27 16:00:45 -05:00
Pāvels Nadtočajevs
15279f769d Fix embedded window frame oversampling, fix DPITexture using uninitialized size in some conditions. 2025-10-25 17:23:45 +03:00
hannes
89aa5137b8 add gui_drag_threshold for viewports 2025-10-24 19:01:25 +02:00
Thaddeus Crews
fbf1c72f15 Merge pull request #90401 from KoBeWi/I_wonder_how_much_this_breaks
Don't redraw invisible CanvasItems
2025-10-24 11:23:02 -05:00
Mike Precup
abfc63b483 Speed up signal disconnects in the editor 2025-10-22 22:27:25 -07:00
kobewi
88a5cd2fe0 Add change_scene_to_node() 2025-10-22 12:21:18 +02:00