noahbackus/godot
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 2 Wiki Activity

Merge pull request #115741 from Joy-less/improve-source-generated-emit-signal-performance

Browse Source 
Improve source-generated `EmitSignal{...}` performance in C#
This commit is contained in:
Thaddeus Crews
2026-03-18 11:43:34 -05:00
parent 8d403a7c0c 027284067c
commit 456bdea954
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators.Tests/TestData/GeneratedSources/EventSignals_ScriptSignals.generated.cs
+1 -1
View File
@@ -34,7 +34,7 @@ partial class EventSignals
}
protected void EmitSignalMySignal(string @str, int @num)
{
EmitSignal(SignalName.MySignal, @str, @num);
EmitSignal(SignalName.MySignal, [@str, @num]);
}
/// <inheritdoc/>
[global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators/ScriptSignalsGenerator.cs
+9 -4
View File
@@ -303,20 +303,25 @@ namespace Godot.SourceGenerators
}
source.Append(")\n");
source.Append(" {\n");
source.Append($" EmitSignal(SignalName.{signalName}");
source.Append($" EmitSignal(SignalName.{signalName}, [");
foreach (var paramSymbol in invokeMethodSymbol.Parameters)
{
if (paramSymbol.Ordinal != 0)
{
source.Append(", ");
}
// Enums must be converted to the underlying type before they can be implicitly converted to Variant
if (paramSymbol.Type.TypeKind == TypeKind.Enum)
{
var underlyingType = ((INamedTypeSymbol)paramSymbol.Type).EnumUnderlyingType!;
source.Append($", ({underlyingType.FullQualifiedNameIncludeGlobal()})@{paramSymbol.Name}");
source.Append($"({underlyingType.FullQualifiedNameIncludeGlobal()})@{paramSymbol.Name}");
continue;
}
source.Append($", @{paramSymbol.Name}");
source.Append($"@{paramSymbol.Name}");
}
source.Append(");\n");
source.Append("]);\n");
source.Append(" }\n");
}