noahbackus/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Merge pull request #118921 from aurpine/remove-unused-fileaccess-create-in-gltf_document

Browse Source 
Remove unused FileAccess::create calls in GLTFDocument
This commit is contained in:
Thaddeus Crews
2026-04-27 12:05:39 -05:00
parent ad6ead96a2 a3bda42c94
commit dfa352d181
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/gltf/gltf_document.cpp
-4
View File
@@ -720,7 +720,6 @@ Error GLTFDocument::_encode_buffer_glb(Ref<GLTFState> p_state, const String &p_p
if (buffer_data.is_empty()) {
return OK;
}
file->create(FileAccess::ACCESS_RESOURCES);
file->store_buffer(buffer_data.ptr(), buffer_data.size());
gltf_buffer["uri"] = filename;
gltf_buffer["byteLength"] = buffer_data.size();
@@ -752,7 +751,6 @@ Error GLTFDocument::_encode_buffer_bins(Ref<GLTFState> p_state, const String &p_
if (buffer_data.is_empty()) {
return OK;
}
file->create(FileAccess::ACCESS_RESOURCES);
file->store_buffer(buffer_data.ptr(), buffer_data.size());
gltf_buffer["uri"] = filename;
gltf_buffer["byteLength"] = buffer_data.size();
@@ -6821,7 +6819,6 @@ Error GLTFDocument::_serialize_file(Ref<GLTFState> p_state, const String p_path)
ERR_FAIL_COND_V_MSG(total_file_length > (uint64_t)UINT32_MAX, ERR_CANT_CREATE,
"glTF: File size exceeds glTF Binary's maximum of 4 GiB. Cannot serialize as a GLB file.");
file->create(FileAccess::ACCESS_RESOURCES);
file->store_32(magic);
file->store_32(p_state->major_version); // version
file->store_32(total_file_length);
@@ -6849,7 +6846,6 @@ Error GLTFDocument::_serialize_file(Ref<GLTFState> p_state, const String p_path)
Ref<FileAccess> file = FileAccess::open(p_path, FileAccess::WRITE, &err);
ERR_FAIL_COND_V(file.is_null(), FAILED);
file->create(FileAccess::ACCESS_RESOURCES);
String json = JSON::stringify(p_state->json, "", true, true);
file->store_string(json);
}