Merge pull request #58596 from rburing/joints_disconnect_connected_signals

`Joint2D` and `Joint3D`: disconnect only connected signals
This commit is contained in:
Rémi Verschelde
2022-02-28 11:00:14 +01:00
committed by GitHub
2 changed files with 6 additions and 6 deletions
+3 -3
View File
@@ -128,7 +128,7 @@ void Joint2D::set_node_a(const NodePath &p_node_a) {
return;
}
if (joint.is_valid()) {
if (is_configured()) {
_disconnect_signals();
}
@@ -145,7 +145,7 @@ void Joint2D::set_node_b(const NodePath &p_node_b) {
return;
}
if (joint.is_valid()) {
if (is_configured()) {
_disconnect_signals();
}
@@ -164,7 +164,7 @@ void Joint2D::_notification(int p_what) {
} break;
case NOTIFICATION_EXIT_TREE: {
if (joint.is_valid()) {
if (is_configured()) {
_disconnect_signals();
_update_joint(true);
}
+3 -3
View File
@@ -124,7 +124,7 @@ void Joint3D::set_node_a(const NodePath &p_node_a) {
return;
}
if (joint.is_valid()) {
if (is_configured()) {
_disconnect_signals();
}
@@ -141,7 +141,7 @@ void Joint3D::set_node_b(const NodePath &p_node_b) {
return;
}
if (joint.is_valid()) {
if (is_configured()) {
_disconnect_signals();
}
@@ -171,7 +171,7 @@ void Joint3D::_notification(int p_what) {
} break;
case NOTIFICATION_EXIT_TREE: {
if (joint.is_valid()) {
if (is_configured()) {
_disconnect_signals();
_update_joint(true);
}