noahbackus/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Merge pull request #119971 from DarioSamo/d3d12-command-list-creation-fix

Browse Source 
Don't use CreateCommandList1 on D3D12.
This commit is contained in:
Thaddeus Crews
2026-06-02 17:39:06 -05:00
parent cbc3aa33f6 568833cb86
commit fc3585607d
1 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/d3d12/rendering_device_driver_d3d12.cpp
+2 -11
View File
@@ -2577,18 +2577,9 @@ RDD::CommandBufferID RenderingDeviceDriverD3D12::command_buffer_create(CommandPo
ComPtr<ID3D12GraphicsCommandList> cmd_list;
{
ComPtr<ID3D12Device4> device_4;
device->QueryInterface(device_4.GetAddressOf());
HRESULT res = E_FAIL;
if (device_4) {
res = device_4->CreateCommandList1(0, list_type, D3D12_COMMAND_LIST_FLAG_NONE, IID_PPV_ARGS(cmd_list.GetAddressOf()));
} else {
res = device->CreateCommandList(0, list_type, cmd_allocator.Get(), nullptr, IID_PPV_ARGS(cmd_list.GetAddressOf()));
}
HRESULT res = device->CreateCommandList(0, list_type, cmd_allocator.Get(), nullptr, IID_PPV_ARGS(cmd_list.GetAddressOf()));
ERR_FAIL_COND_V_MSG(!SUCCEEDED(res), CommandBufferID(), "CreateCommandList failed with error " + vformat("0x%08ux", (uint64_t)res) + ".");
if (!device_4) {
cmd_list->Close();
}
cmd_list->Close();
}
CPUDescriptorHeapPool::Allocation uav_alloc;